-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(anta): add test atomic results #937
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #937 will degrade performances by 23.36%Comparing Summary
Benchmarks breakdown
|
add_result(result) | ||
return table | ||
|
||
def report(self, manager: ResultManager) -> Table: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to make this non breaking we need to keep report_all
function with the possibility to change the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is internal to ANTA. The title argument should have never been there anyway since it's always the default value... It is never used.
console.print("Tags found:") | ||
console.print_json(json.dumps(sorted(tags), indent=2)) | ||
t.update(device.tags) | ||
console.print("Tags defined in inventory:") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to update the documentation
pytest.param(None, 5, 5, id="all results"), | ||
pytest.param(None, 0, 0, id="result for host1 when no host1 test"), | ||
pytest.param(None, 5, 5, id="result for test VerifyTest3"), | ||
pytest.param("Custom title", 5, 5, id="Change table title"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will probably need to add this back to be non breaking
Co-authored-by: Guillaume Mulocher <[email protected]>
Quality Gate passedIssues Measures |
Description
Add anta.result_manager.models.AtomicTestResult model.
Create a
atomic_results
field inanta.result_manager.models.TestResult
model.Reports supported are
table
,text
,json
andjinja
.csv
andmarkdown
will be supported in another PR.Considering the test:
The exemple below is a serialisation of the
TestResult
model of the test defined above:Fixes #427
Checklist:
pre-commit run
)tox -e testenv
)